cc/pkg-config: handle tuple *cflags* and *ldflags* #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently using :pkg-config-libs with declare-executable gives the following error: error: bad slot #0, expected array, got <tuple 0x7C2127E0CE00> in array/concat [src/core/array.c] on line 250 in pkg-config [/home/ifreund/.local/lib/janet/spork/cc.janet] (tail call) on line 749, column 3 in target [/home/ifreund/.local/lib/janet/spork/declare-cc.janet] on line 828, column 11 in edefer [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 118, column 22 in _while [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 112, column 7 in worker [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 105, column 5 in defer [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 19, column 11 in wait-for-fibers [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 12, column 3 in run-rules [/home/ifreund/.local/lib/janet/spork/build-rules.janet] (tail call) on line 132, column 3 in run-main [boot.janet] on line 4523, column 16 in cli-main [boot.janet] on line 4745, column 17 We could try to ensure that *cflags*/*ldflags* are always an array, but simply guarding against the chance that they could be a tuple in cc/pkg-config seems more robust.
|
LGTM. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using :pkg-config-libs with declare-executable gives the following error:
error: bad slot #0, expected array, got <tuple 0x7C2127E0CE00>
in array/concat [src/core/array.c] on line 250
in pkg-config [/home/ifreund/.local/lib/janet/spork/cc.janet] (tail call) on line 749, column 3
in target [/home/ifreund/.local/lib/janet/spork/declare-cc.janet] on line 828, column 11
in edefer [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 118, column 22
in _while [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 112, column 7
in worker [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 105, column 5
in defer [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 19, column 11
in wait-for-fibers [/home/ifreund/.local/lib/janet/spork/build-rules.janet] on line 12, column 3
in run-rules [/home/ifreund/.local/lib/janet/spork/build-rules.janet] (tail call) on line 132, column 3
in run-main [boot.janet] on line 4523, column 16
in cli-main [boot.janet] on line 4745, column 17
We could try to ensure that cflags/ldflags are always an array, but simply guarding against the chance that they could be a tuple in cc/pkg-config seems more robust.