Skip to content

Conversation

chickdan
Copy link
Contributor

@chickdan chickdan commented Mar 5, 2025

Utilizing https://github.com/ViacomInc/TVOSPicker mentioned in #1419 this PR closely follows the iOS implementation.

timeout.mp4

@JPKribs
Copy link
Member

JPKribs commented Mar 5, 2025

In one of the other PR that I have open, I wanted to do something similar to the blurred full screen and was running into a similar error. So, I ended up adding the view to the coordinator and calling it with .fullScreen instead of .push or .modal.

I was basing it off of the item overview, which does this same thing:

https://github.com/jellyfin/Swiftfin/blob/main/Swiftfin%20tvOS/Views/ItemOverviewView.swift


I ended up doing it at the same way for both my open playlist and filters PR. It's kind of a pain and adds an extra step, but it should work for getting you past that issue! I did it here with the filter:

https://github.com/JPKribs/Swiftfin/blob/tvOSLetterPicker/Shared/Coordinators/LibraryCoordinator.swift

@JPKribs JPKribs added the enhancement New feature or request label Mar 6, 2025
@chickdan
Copy link
Contributor Author

chickdan commented Mar 12, 2025

Thank you for the suggestion, it is no longer crashing! Still some work left to do though.

Edit: and working now. It's not the cleanest implementation so suggestions are welcome.

@chickdan chickdan marked this pull request as ready for review March 12, 2025 02:53
@chickdan chickdan changed the title [WIP] [tvOS] Sign-In Flow - User Auto Time-Out [tvOS] Sign-In Flow - User Auto Time-Out Mar 12, 2025
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now, albeit simple since we're using another package. I realize that implementing a ticker like this probably isn't difficult in SwiftUI and in today's age of asking an AI to do it.

I'm not against investigating our own picker for this type of data as well as building out the view itself so it isn't so plain. I also thought that per-minute was probably a bit too much and thought 5 minutes would have been better (would also change iOS). Thoughts?

@LePips LePips merged commit 1eef7c9 into jellyfin:main Mar 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants