-
-
Notifications
You must be signed in to change notification settings - Fork 388
[tvOS] Sign-In Flow - User Auto Time-Out #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In one of the other PR that I have open, I wanted to do something similar to the blurred full screen and was running into a similar error. So, I ended up adding the view to the coordinator and calling it with I was basing it off of the item overview, which does this same thing: https://github.com/jellyfin/Swiftfin/blob/main/Swiftfin%20tvOS/Views/ItemOverviewView.swift I ended up doing it at the same way for both my open playlist and filters PR. It's kind of a pain and adds an extra step, but it should work for getting you past that issue! I did it here with the filter: |
Thank you for the suggestion, it is no longer crashing! Still some work left to do though. Edit: and working now. It's not the cleanest implementation so suggestions are welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for now, albeit simple since we're using another package. I realize that implementing a ticker like this probably isn't difficult in SwiftUI and in today's age of asking an AI to do it.
I'm not against investigating our own picker for this type of data as well as building out the view itself so it isn't so plain. I also thought that per-minute was probably a bit too much and thought 5 minutes would have been better (would also change iOS). Thoughts?
Utilizing https://github.com/ViacomInc/TVOSPicker mentioned in #1419 this PR closely follows the iOS implementation.
timeout.mp4