Skip to content

Conversation

darinpope
Copy link
Contributor

Update tests in order to be able to add plugin to BOM

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@darinpope darinpope requested a review from kuisathaverat as a code owner June 5, 2025 18:52
@kuisathaverat
Copy link
Contributor

I'm not sure what changed; there is one deleted file and two entirely new files. This change requires extra time to verify the changes because I cannot compare the old code with the new code; I have to verify them all.

@darinpope
Copy link
Contributor Author

Sorry. I should have explained what I did too. I broke apart the deleted file and extracted each static to their own file, keeping the common content outside of the statics. I'm hoping that will get us to the point we can add to bom.

@kuisathaverat kuisathaverat merged commit 6c181a8 into jenkinsci:main Jun 6, 2025
17 checks passed
@darinpope darinpope deleted the fix-tests branch June 18, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants