Only finalize mapped all from Go when map entry exists #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was still a double finalization race, detected by the panic introduced by the previous commit. If setErr() is called during client teardown, all currently managed calls will be errored and finalized, and the calls map set to nil. Unfortunately, Client.Go was again finalizing the call even after setErr released the calls mutex, because it had a another variable pointing to it. To fix this race, look up the call entry in the map and only finalize and delete it when it present.
dajohi
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was still a double finalization race, detected by the panic introduced by the previous commit. If setErr() is called during client teardown, all currently managed calls will be errored and finalized, and the calls map set to nil.
Unfortunately, Client.Go was again finalizing the call even after setErr released the calls mutex, because it had a another variable pointing to it.
To fix this race, look up the call entry in the map and only finalize and delete it when it present.