Skip to content

Conversation

Vixtir
Copy link
Contributor

@Vixtir Vixtir commented Jul 8, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Added common wrapper FilterContainer for all columns filter, that encapsulate logic of renred icons and positioning of passed filter variant component
Fixes #621

Added frontend filters for ACL table

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Vixtir Vixtir requested a review from a team as a code owner July 8, 2025 18:00
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/acl scope/frontend Related to frontend changes status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 8, 2025
@Vixtir Vixtir merged commit 86b8cac into main Jul 9, 2025
17 checks passed
@Vixtir Vixtir deleted the acl_frontend_filters branch July 9, 2025 14:26
@Haarolean Haarolean added area/ux User experiense issues and removed status/triage/manual Manual triage in progress labels Jul 15, 2025
@Haarolean Haarolean added this to the 1.3 milestone Jul 15, 2025
@Haarolean Haarolean moved this from Todo to Done in Release 1.3 Jul 15, 2025
@Haarolean Haarolean added the type/enhancement En enhancement/improvement to an already existing feature label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/acl area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ACL: Impl search/filters
4 participants