Skip to content

Conversation

wernerdv
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
In this PR I added CustomSslSocketFactory that trusts all certificates by default.
This allows you to use LDAPS to connect to an AD server without further specifying the path to the truststore/password.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner February 13, 2025 07:13
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/rbac Related to Role Based Access Control feature status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 13, 2025
@wernerdv
Copy link
Contributor Author

@Haarolean PTAL

@Haarolean Haarolean changed the title BE: RBAC: Support LDAPS for AD BE: Auth: Support LDAPS for AD Feb 13, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/auth App authentication related issues and removed area/rbac Related to Role Based Access Control feature status/triage/manual Manual triage in progress labels Feb 13, 2025
@wernerdv wernerdv requested a review from Haarolean February 13, 2025 13:44
@Haarolean Haarolean added this to the 1.2 milestone Feb 14, 2025
@Haarolean Haarolean merged commit 49894b8 into kafbat:main Feb 19, 2025
13 of 15 checks passed
@Haarolean
Copy link
Member

@wernerdv thanks!

@wernerdv wernerdv deleted the support_ldaps_ad branch February 19, 2025 10:25
@Haarolean Haarolean mentioned this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth App authentication related issues scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants