remove ctime for musl environment #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think what we can have is a default SystemTime value (like default unix epoch time or something) when compiling to musl target How does that sound? |
If users notice that all their files were created on 1970-01-01, wouldn't they feel confused? |
kamiyaa
approved these changes
Sep 28, 2024
Signed-off-by: usamoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#549 introduces "ctime" linemode but it makes joshuto immediately panic because it calls
Metadata::created. Forx86_64-unknown-linux-musltarget, it always panics.This PR removes "ctime" temporaily.
You can merge this PR and revert this PR when
Metadata::createdis supported for musl in Rust.