Skip to content

Kab 1124 add links to detail tools #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Jun 23, 2025
Merged

Kab 1124 add links to detail tools #165

merged 44 commits into from
Jun 23, 2025

Conversation

ncapek
Copy link
Contributor

@ncapek ncapek commented Jun 12, 2025

This PR adds links to objects fetched by get_xxx_detail tools.

@ncapek ncapek marked this pull request as draft June 12, 2025 10:30
@ncapek ncapek marked this pull request as ready for review June 12, 2025 13:51
radcliffkey
radcliffkey reviewed Jun 13, 2025
View reviewed changes
radcliffkey
radcliffkey reviewed Jun 13, 2025
View reviewed changes
@radcliffkey
Copy link
Contributor

radcliffkey commented Jun 13, 2025 •
edited
Loading

Throughout the code, please prefer using keyword (named) arguments (f(arg=value)) over positional. It is less error prone and better readable.

radcliffkey
radcliffkey reviewed Jun 13, 2025
View reviewed changes
@radcliffkey
Copy link
Contributor

Please add links checking to the existing integration tests where applicable

mariankrotil
mariankrotil approved these changes Jun 13, 2025
View reviewed changes
vita-stejskal
vita-stejskal approved these changes Jun 19, 2025
View reviewed changes
@mariankrotil mariankrotil mentioned this pull request Jun 23, 2025
Merged
radcliffkey
radcliffkey reviewed Jun 23, 2025
View reviewed changes
radcliffkey
radcliffkey reviewed Jun 23, 2025
View reviewed changes
radcliffkey
radcliffkey reviewed Jun 23, 2025
View reviewed changes
radcliffkey
radcliffkey reviewed Jun 23, 2025
View reviewed changes
radcliffkey
radcliffkey reviewed Jun 23, 2025
View reviewed changes
@ncapek ncapek merged commit d093e9e into main Jun 23, 2025
19 checks passed
@ncapek ncapek deleted the KAB-1124-add-links-to-detail-tools branch June 23, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radcliffkey radcliffkey radcliffkey left review comments

@vita-stejskal vita-stejskal vita-stejskal approved these changes

@mariankrotil mariankrotil mariankrotil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncapek @radcliffkey @vita-stejskal @mariankrotil