feat: add OAuth URL generation tool #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add create_oauth_url tool to generate OAuth authorization URLs - Creates short-lived SAPI tokens with component-specific access - Supports OAuth-requiring components (ex-google-analytics-v4, ex-gmail) - Returns OAuth URL string for external authorization flow - Add comprehensive tests with 100% pass rate - Update server tool registry and documentation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fix code style violations (quotes, whitespace, line length) - Apply black formatting and isort - Fix parametrize format in tests - Add missing newlines at end of files - All tests still pass (6/6) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Development information is already available in README.md 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
@jordanrburger it is working in Cursor for me :) The only disadvantage is that the user has to manually let the LLM know that it is done. |
AdamVyborny
commented
Jul 22, 2025
radcliffkey
reviewed
Jul 23, 2025
Replace raw HTTP calls with proper client method abstraction for token creation. Add token_create method to AsyncStorageClient with comprehensive test coverage. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
radcliffkey
approved these changes
Jul 24, 2025
Co-authored-by: Radoslav Klic <[email protected]>
Replace direct session state access with proper KeboolaClient pattern throughout the OAuth test file for consistency with project conventions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
radcliffkey
approved these changes
Jul 24, 2025
AdamVyborny
commented
Jul 24, 2025
| oauth_url = ( | ||
| f'https://external.keboola.com/oauth/index.html?token={sapi_token}' | ||
| f'&sapiUrl={storage_api_url}#/{component_id}/{config_id}' | ||
| ) |
There was a problem hiding this comment.
I think that the query part parameters should be properly encoded by using urllib.parse.urlencode function and the whole URL should be constructed using urllib.parse.urlunsplit function.
There was a problem hiding this comment.
I will look into it and fix in follow-up PR. Thanks.
AdamVyborny
added a commit
that referenced
this pull request
Jul 28, 2025
Replace manual string concatenation with urllib.parse functions for secure URL construction: - Use urlencode() for query parameters to prevent injection - Use urlunsplit() for proper URL assembly - Update tests to match encoded output Addresses: #211 (comment) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
create_oauth_urltool for OAuth-requiring component configurationskeboola.ex-google-analytics-v4andkeboola.ex-gmailTest plan
Integration Test Rationale
Integration tests were not added because:
external.keboola.com)🤖 Generated with Claude Code