Skip to content

Conversation

radektomasek
Copy link
Contributor

Description

This PR contains several fixes, including:

  • addressed the issue with the 'query_table_data' method that wasn't able to query requested data. The issue was caused by the fact the DB_NAME was prefixed with a hardcoded value.
  • added a detail description to the DB methods. The change should help the AI tool to understand the context a better way
  • fixed linting issues
  • updated tests

…le to query requested data. The issue was caused by the fact the DB_NAME was prefixed with a hardcoded value.

The change also contain a description that help the AI tool to understand the context a better way
@radektomasek radektomasek self-assigned this Jan 30, 2025
@radektomasek radektomasek marked this pull request as draft January 31, 2025 05:58
…ion of the DB logic from the sever.py

There is a new class including connection_management that uses pattern matching to check various connection DB_name and verify which works. This makes a more robust solution in case there are various DB options inside of the project - the tool just tries a valid connection string and keep (cache) the connection that worked.
@davidesner davidesner marked this pull request as ready for review February 18, 2025 10:40
@davidesner
Copy link
Contributor

I simplified things optimised the instructions, removed the simplified endpoint as it didn't bring any value. Removed some import sort checks and mypy for now as it was only annoying

@jordanrburger jordanrburger merged commit b44a727 into master Feb 18, 2025
3 checks passed
@vita-stejskal vita-stejskal deleted the sql-interface-adjustments branch March 28, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants