Some cleanup // Optimizers #18124
Merged
Some cleanup // Optimizers #18124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachinprasadhs
added
the
keras-team-review-pending
rchao
reviewed
May 18, 2023
rchao
removed
the
keras-team-review-pending
google-ml-butler
bot
added
kokoro:force-run
ready to pull
haifeng-jin
suggested changes
May 22, 2023
google-ml-butler
bot
removed
the
ready to pull
haifeng-jin
approved these changes
May 22, 2023
google-ml-butler
bot
added
kokoro:force-run
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
May 23, 2023
Imported from GitHub PR #18124 This PR: * Migrates docstrings into 4 indents * Removes unused args in adam & adamw Copybara import of the project: -- f8c2982 by Kaan Bıçakcı <[email protected]>: Remove unused args -- 0775e6b by Kaan Bıçakcı <[email protected]>: adamw docstring update -- 7999975 by Kaan Bıçakcı <[email protected]>: Adadelta docstring update -- a99442b by Kaan Bıçakcı <[email protected]>: adafactor docstring update -- 070dd88 by Kaan Bıçakcı <[email protected]>: adagrad docstring update -- 49e5689 by Kaan Bıçakcı <[email protected]>: Remove unused args // adam -- 6b0a4da by Kaan Bıçakcı <[email protected]>: Adam docstring update -- 53a87b9 by Kaan Bıçakcı <[email protected]>: FTRL docstring update -- e47d096 by Kaan Bıçakcı <[email protected]>: Adamax docstring update -- 3811ee2 by Kaan Bıçakcı <[email protected]>: Lion docstring update -- 7452374 by Kaan Bıçakcı <[email protected]>: Nadam docstring update -- 11d682e by Kaan Bıçakcı <[email protected]>: RMS docstring update -- 69070b4 by Kaan Bıçakcı <[email protected]>: Fix linting -- 7fe95d6 by Kaan Bıçakcı <[email protected]>: Update indent for unupdated params -- 4855354 by Kaan Bıçakcı <[email protected]>: SGD docstring update -- 3b3403c by Kaan Bıçakcı <[email protected]>: Fix adagrad indent Merging this change closes #18124 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18124 from Frightera:cleanup 3b3403c PiperOrigin-RevId: 534171670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: