Refactor test cases to improve unit test quality #18303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
gbaned
added
the
keras-team-review-pending
grasskin
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Hi @freddiewanah, thank you for the PR! Test changes look good.
google-ml-butler
bot
added
kokoro:force-run
ready to pull
grasskin
removed
the
keras-team-review-pending
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
Imported from GitHub PR #18303 Hello, first-time submitting PR here. I've read through the contributor guide and figured it's a minor update, hence this PR. This PR improves the readability of the assert statements in some of the unit tests by using more expressive assert methods from the unittest module. These changes improve code quality (avoid test smells) by: - Making the assert statements more readable and consistent with other asserts in the same test file, i.e., assertLen. Happy to update more related issues in the test code if needed :) Copybara import of the project: -- d823be2 by freddiewanah <[email protected]>: Refactor test cases to improve unit test quality -- ddeff03 by freddiewanah <[email protected]>: revert assertRaisesRegex Merging this change closes #18303 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18303 from freddiewanah:master ddeff03 PiperOrigin-RevId: 551893138
gbaned
added
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 31, 2023
Imported from GitHub PR #18303 Hello, first-time submitting PR here. I've read through the contributor guide and figured it's a minor update, hence this PR. This PR improves the readability of the assert statements in some of the unit tests by using more expressive assert methods from the unittest module. These changes improve code quality (avoid test smells) by: - Making the assert statements more readable and consistent with other asserts in the same test file, i.e., assertLen. Happy to update more related issues in the test code if needed :) Copybara import of the project: -- d823be2 by freddiewanah <[email protected]>: Refactor test cases to improve unit test quality -- ddeff03 by freddiewanah <[email protected]>: revert assertRaisesRegex Merging this change closes #18303 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18303 from freddiewanah:master ddeff03 PiperOrigin-RevId: 551893138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first-time submitting PR here. I've read through the contributor guide and figured it's a minor update, hence this PR.
This PR improves the readability of the assert statements in some of the unit tests by using more expressive assert methods from the unittest module. These changes improve code quality (avoid test smells) by:
Happy to update more related issues in the test code if needed :)