Skip to content

Fix typo in keras.distribution.initialize #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix typo in keras.distribution.initialize #19201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions keras/backend/jax/distribution_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ def initialize(job_addresses, num_processes, process_id):
f"{len(job_addresses)} jobs, but num_processes is "
f"{num_processes}"
)
corrdinator_address = job_addresses[0]
coordinator_address = job_addresses[0]
else:
corrdinator_address = job_addresses
coordinator_address = job_addresses

jax.distributed.initialize(
corrdinator_address=corrdinator_address,
coordinator_address=coordinator_address,
num_processes=num_processes,
process_id=process_id,
)
Expand Down
4 changes: 2 additions & 2 deletions keras/backend/jax/distribution_lib_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def test_device_conversion(self):
def test_initialize_with_all_job_addresses(self, mock_jax_initialze):
backend_dlib.initialize("10.0.0.1:1234,10.0.0.2:2345", 2, 0)
mock_jax_initialze.assert_called_once_with(
corrdinator_address="10.0.0.1:1234", num_processes=2, process_id=0
coordinator_address="10.0.0.1:1234", num_processes=2, process_id=0
)

def test_initialize_validate_job_and_process(self):
Expand All @@ -63,7 +63,7 @@ def test_initialize_validate_job_and_process(self):
def test_initialize_with_coordinater_address(self, mock_jax_initialze):
backend_dlib.initialize("10.0.0.1:1234", 2, 0)
mock_jax_initialze.assert_called_once_with(
corrdinator_address="10.0.0.1:1234", num_processes=2, process_id=0
coordinator_address="10.0.0.1:1234", num_processes=2, process_id=0
)

def test_distribute_tensor(self):
Expand Down