Skip to content

Conversation

tirthasheshpatel
Copy link
Contributor

Fixes #19299

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.55%. Comparing base (c8700f4) to head (286a89b).
Report is 1183 commits behind head on master.

Files with missing lines Patch % Lines
keras/ops/nn.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19300      +/-   ##
==========================================
- Coverage   80.14%   75.55%   -4.59%     
==========================================
  Files         341      365      +24     
  Lines       36163    39861    +3698     
  Branches     7116     7747     +631     
==========================================
+ Hits        28982    30118    +1136     
- Misses       5578     8062    +2484     
- Partials     1603     1681      +78     
Flag Coverage Δ
keras 75.40% <0.00%> (-4.59%) ⬇️
keras-jax 59.64% <0.00%> (-3.42%) ⬇️
keras-numpy 54.19% <0.00%> (-2.90%) ⬇️
keras-tensorflow 61.15% <0.00%> (-3.51%) ⬇️
keras-torch 60.26% <0.00%> (-3.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Mar 13, 2024
@fchollet fchollet merged commit 6a266b8 into keras-team:master Mar 13, 2024
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

keras.ops.softmax errors out when used in a TensorFlow compiled function
4 participants