Propagate safe_mode flag to legacy h5 loading code.
#21602
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the legacy H5 model loading mechanism by introducing and propagating a safe_mode flag, which prevents the deserialization of potentially unsafe custom objects by default. It also includes a cleanup of obsolete code related to string replacement in legacy saving utilities and reactivates previously commented-out unit tests to ensure the new safe_mode behavior is correctly validated.
Highlights
- Enhanced H5 Model Loading Safety: The
load_model_from_hdf5function in the legacy H5 format now accepts asafe_modeargument, ensuring that potentially unsafe deserialization operations are blocked by default, improving security. - Removal of Redundant Code: Obsolete
_find_replace_nested_dictfunctions and their associated calls have been removed from legacy saving utilities, streamlining the codebase and removing no-op operations. - Activated Unit Tests: Previously commented-out unit tests in
serialization_lib_test.pyrelated tolambdalayers andsafe_modefunctionality have been re-enabled, confirming the correct behavior of the new safety measures.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly propagates the safe_mode flag to the legacy H5 model loading functionality, ensuring consistent behavior for unsafe deserialization across different model formats. The changes also include beneficial code cleanup by removing no-op code from legacy saving utilities. Additionally, previously disabled unit tests for lambda serialization have been re-enabled. However, I've found that the updated tests use an incorrect regular expression to catch the expected ValueError, which will cause them to fail. I've provided suggestions to fix these tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21602 +/- ##
==========================================
+ Coverage 76.94% 82.71% +5.76%
==========================================
Files 568 568
Lines 56895 56897 +2
Branches 8889 8890 +1
==========================================
+ Hits 43780 47063 +3283
+ Misses 10862 7640 -3222
+ Partials 2253 2194 -59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also: - made various error messages related to `safe_mode` more consistent - removed no-op renaming code in legacy saving - uncommented unit tests in `serialization_lib_test.py`
hertschuh
force-pushed
the
h5_safe_mode
branch
from
432f705 to
028c199
Compare
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
Also: - made various error messages related to `safe_mode` more consistent - removed no-op renaming code in legacy saving - uncommented unit tests in `serialization_lib_test.py`
* Disable `torch.load` in `TorchModuleWrapper` when in safe mode. (#21575) Raise an exception and explain the user about the risks. * Propagate `safe_mode` flag to legacy h5 loading code. (#21602) Also: - made various error messages related to `safe_mode` more consistent - removed no-op renaming code in legacy saving - uncommented unit tests in `serialization_lib_test.py` * Fix GRU with return_state=True on tf backend with cuda (#21603) * Version bump to 3.11.3 --------- Co-authored-by: hertschuh <[email protected]> Co-authored-by: Matt Watson <[email protected]>
Also:
serialization_lib_test.pysafe_modemore consistent