health: Improve health check reliability, old one doesnt detect thread crash #1301
+112
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuclearcat
force-pushed
the
health-improve
branch
4 times, most recently
from
8ba961e to
02b23e9
Compare
The current health check only monitors heartbeat updates but fails to detect when individual scheduler threads crash or become unresponsive. This is problematic because threads use blocking event loops that can wait for hours, making it impossible to distinguish between legitimate waiting and actual crashes. The health check now detects: - Completely crashed/dead threads via thread.is_alive() - Missing threads from failed startup - Thread restart frequency from exception handling - Overall thread pool health status Signed-off-by: Denys Fedoryshchenko <[email protected]>
nuclearcat
force-pushed
the
health-improve
branch
from
02b23e9 to
2a35449
Compare
|
nice! |
aliceinwire
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.