Skip to content

Conversation

MrHPotter
Copy link

Just felt this was missing, when i was getting started with this provider

@sschu
Copy link
Contributor

sschu commented Jun 20, 2025

@MrHPotter Thanks for the contribution! I do see the benefit in having this available in the documentation. The downside is, it really depends on the Keycloak version you are using and the list might get outdated. But since Keycloak itself doesnt have such a list in one place in its documentation, I am fine with adding it here.

- `user_name` - (Required) The username of the user defined in the identity provider
- `import` - (Optional) When `true`, the user with the specified `username` is assumed to already exist, and it will be imported into state instead of being created. This attribute is useful when dealing with users that Keycloak creates automatically during realm creation, such as `admin`. Note, that the user will not be removed during destruction if `import` is `true`.

## Valid Required Actions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not add these actions in an extra section but stick to the standard format listing the options in the description of the parameter with "Valid options are: CONFIGURE_TOTP, ..." I would also use the order as defined by Keycloak in its source code, makes it easier to maintain and spot differences, see https://github.com/keycloak/keycloak/blob/b9442b169066f93977a6e8b22a4b76b2e7b86c94/server-spi-private/src/main/java/org/keycloak/models/utils/DefaultRequiredActions.java#L74-L86

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MrHPotter are you still interested in landing this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked your ideas for improvement. Woll just have to remember at a time where i can put it into action. If you know where and how you'd like it i would not be offended if you took pver either and just did it tho.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now another PR also adding some extended information https://github.com/keycloak/terraform-provider-keycloak/pull/1308/files. I think we will just go with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants