provider/github: init OIDC provider for GitHub #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaitoBezarius
force-pushed
the
github-idp
branch
2 times, most recently
from
9398090 to
57c876c
Compare
|
This now was tested in production on an actual deployment successfully. |
RaitoBezarius
force-pushed
the
github-idp
branch
from
57c876c to
4fe7fcf
Compare
sschu
requested changes
Sep 3, 2025
There was a problem hiding this comment.
@RaitoBezarius Thanks for the PR. Generally looks good to me. Can you please also add some documentation for the new resource? You could use https://github.com/keycloak/terraform-provider-keycloak/blob/e3e1d90bbbf01fad43799ea5bc732bba7fc6a962/docs/resources/oidc_google_identity_provider.md as inspiration.
GitHub has a special OIDC provider with provider ID := github. This contains a certain number of interesting special properties w.r.t. to email retrieval logic (select the primary email, etc.). It's superior to the generic OIDC one. Signed-off-by: Raito Bezarius <[email protected]>
RaitoBezarius
force-pushed
the
github-idp
branch
from
c712c92 to
e998b23
Compare
|
@sschu Apologies for the delay, this is now done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub has a special OIDC provider with provider ID := github.
This contains a certain number of interesting special properties w.r.t.
to email retrieval logic (select the primary email, etc.).
It's superior to the generic OIDC one.
Signed-off-by: Raito Bezarius [email protected]