Error end animation

[KingOfDragons]

When i hide de progress bar and reste to 0 it show me this in the log!!

TypeError: this._finish is undefined


this._finish.call(this, this._currentState, this._attachment);

[kimmobrunfeldt]

Could you create a reproducable example in JSFiddle?

[johanrosenson]

I don't have a fiddle for you but i have tracked the down the error.

on row 221:
step(targetState, tweenable._attachment, timeoutHandler_offset);
tweenable.stop(true);

if stop is called from within the step during the last iteration the error will appear when tweenable.stop(true) is called.

[kimmobrunfeldt]

Thanks for reporting this. It occurs because we are calling .dispose() method of the underlying shifty Tweenable here:

progressbar.js/src/path.js

Line 155 in df29df4

this._tweenable.dispose();

The dispose shouldn't be necessary as we are letting go of the tweenable reference. If I confirmation to this from shifty author in this issue jeremyckahn/shifty#86, I can safely remove the dispose call and it will fix this issue.

[kimmobrunfeldt]

Fix to this released in 1.0.0 https://github.com/kimmobrunfeldt/progressbar.js/releases/tag/1.0.0