Reset Timeline Rework #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversalzburg
added
prio:important
oliversalzburg
force-pushed
the
fix/reset-timeline
branch
from
2dc0ba0 to
15a0b6d
Compare
oliversalzburg
force-pushed
the
fix/reset-timeline
branch
5 times, most recently
from
05d5dc7 to
31db4a0
Compare
oliversalzburg
force-pushed
the
fix/reset-timeline
branch
3 times, most recently
from
4da4ec9 to
da051c1
Compare
Previously, pretty much any option in the Reset Timeline automation, was enabled by default, and set to infinite. This indicates that you need an infinite amount of pretty much everything, for the game to be reset. The new defaults are safe, in that they are disabled by default, but retain the infinite value. This makes it safe for the user to adjust either the amount or the enabled state first, without causing anything unexpected. Fixes #183
Allows us to define which upgrades must have been purchased for the game to be reset. Fixes #187
The other options could lead to very confusing states when a reset is actually cancelled.
The flood of log messages isn't ideal, but this can be optimized later. Assigning only a single kitten per frame is exhausting to watch.
oliversalzburg
force-pushed
the
fix/reset-timeline
branch
from
da051c1 to
a6d20f4
Compare
oliversalzburg
removed
the
needs:work
oliversalzburg
added
status:completed
github-actions
bot
added
needs:triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reset Timeline aka Auto-Reset feature has been tested extensively, and several bugs could be fixed. Additionally, some requested features could also be implemented.
The previous default configuration for the Auto-Reset wasn't really a good choice. You really want to make sure to only have those items enabled that should be taken into consideration for the game to be reset, and that they are not set to Infinite.
The Time Control section is now also fully documented.