Refactor internal data structures to use KG types as source of truth #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversalzburg
added
prio:important
hyx3179
force-pushed
the
loops-replace
branch
2 times, most recently
from
938a6f6 to
404e016
Compare
i18n Modifier keys: * "filter.time.skip" -> "filter.timeSkip" * "option.faith.refineTCs" -> "option.faith.refineTimeCrystals" i18n Add keys: "option.faith.autoPraise"
* Use KG array as index
* Use KG array as index and directly use KG label
oliversalzburg
added
needs:merge
|
This change is something I also planned to move towards to in the long term. It is surely the right thing to do. I was always concerned that it could introduce breaking changes. For example, maybe loading old settings could break. A lot of these concerns are for historical reasons. Maybe I was too scared to make this big change. I'm very thankful that you took on this big task. Your refactoring looks great. I feel like it's very consistent with the existing code style. Thanks for being considerate. I'll merge this quickly to enable a larger audience to evaluate these changes. ❤️ |
oliversalzburg
changed the title
oliversalzburg
added
status:completed
github-actions
bot
added
needs:triage
oliversalzburg
removed
prio:important
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we add the KG project and only need to modify one place