Clean up GUI solution code #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliversalzburg
force-pushed
the
feat/ui-consolidate
branch
5 times, most recently
from
3a23d4f to
3e5619f
Compare
oliversalzburg
added
prio:important
oliversalzburg
force-pushed
the
feat/ui-consolidate
branch
from
3e5619f to
dada3a4
Compare
oliversalzburg
changed the title
oliversalzburg
force-pushed
the
feat/ui-consolidate
branch
3 times, most recently
from
eb557c5 to
a61b183
Compare
oliversalzburg
force-pushed
the
feat/ui-consolidate
branch
2 times, most recently
from
2306f69 to
6dd70ca
Compare
oliversalzburg
force-pushed
the
feat/ui-consolidate
branch
from
6dd70ca to
0ab9afb
Compare
oliversalzburg
force-pushed
the
feat/ui-consolidate
branch
3 times, most recently
from
e25ef25 to
e49e520
Compare
oliversalzburg
force-pushed
the
feat/ui-consolidate
branch
from
e49e520 to
f1795b4
Compare
oliversalzburg
added
needs:testing
github-actions
bot
added
needs:triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate GUI solutions to allow for refactoring.
Signalling ineffective (default) states to the user required a major rebuild of the UI framework to allow for reactivity. Anything that previously existed in the UI in that area, was purely driven by long function call chains. There is still some of that, but all components now utilize the same solutions, instead of rolling 12 individual ones. All components are now also properly ordered into a parent-child-hierarchy to efficiently determine which elements need to be refreshed. It's a lot of ground work with probably very little effect for the time being, but it was a massive undertaking