-
Notifications
You must be signed in to change notification settings - Fork 626
🐛 Make print-policy consistent with print-cloudformation-template #5654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Make print-policy consistent with print-cloudformation-template #5654
Conversation
Previously, print-policy claimed to output all policies, but in fact it missed some policies, because it did not use the code as print-cloudformation-template. This change makes print-policy use the same code, making it consistent. Also, print-policy would not output valid JSON, but rather multiple, concatenated JSON documents. It now outputs all policies as a valid JSON object, where the keys are policy names, and the values are the policies.
/lgtm |
LGTM label has been added. Git tree hash: a5af1864f6082590300bf012e69e0bd2007906ce
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardcase The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-2.9 release-2.8 |
@dlipovetsky: new pull request created: #5658 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherrypick release-2.8 |
@dlipovetsky: new pull request created: #5659 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Previously, print-policy claimed to output all policies, but in fact it missed some policies, because it did not use the code as print-cloudformation-template. This change makes print-policy use the same code, making it consistent.
Also, print-policy would not output valid JSON, but rather multiple, concatenated JSON documents. It now outputs all policies as a valid JSON object, where the keys are policy names, and the values are the policies.
Before:
> clusterawsadm bootstrap iam print-policy AWSIAMManagedPolicyControllers { ... } AWSIAMManagedPolicyControllersEKS { ... } AWSIAMManagedPolicyCloudProviderControlPlane { ... }
After
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4339
Special notes for your reviewer:
Checklist:
Release note: