Fix: Correct permissions for downloaded artifacts #12409
+5
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ErikJiang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
ErikJiang
force-pushed
the
skip_set_mode_owner
branch
2 times, most recently
from
6e99a30 to
103b889
Compare
k8s-ci-robot
added
size/M
ErikJiang
changed the title
Signed-off-by: bo.jiang <[email protected]>
ErikJiang
force-pushed
the
skip_set_mode_owner
branch
from
103b889 to
c23671b
Compare
yankay
reviewed
Aug 5, 2025
| dest: "{{ local_release_dir }}/" | ||
| remote_src: true | ||
| when: container_manager in ['crio', 'containerd'] | ||
|
|
There was a problem hiding this comment.
HI @ErikJiang
Why delete this part ?
There was a problem hiding this comment.
The unarchive operation is already configured via downloads.etcd.unarchive: true, so the extraction in extract_file.yml will handle it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes incorrect 0755 (executable) permissions on downloaded archives.
These changes ensure archives receive the correct 0644 permissions, while extracted binaries are correctly set to 0755.
Which issue(s) this PR fixes:
Fixes #12403
Special notes for your reviewer:
Does this PR introduce a user-facing change?: