Skip to content

crio: add option pull_progress_timeout #12555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

crio: add option pull_progress_timeout #12555

wants to merge 1 commit into from
+10 −0

Conversation

pedro-peter
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:
pulling large container images can fail with error:

pulling image: rpc error: code = Canceled desc = copying system image from manifest list: copying config: context canceled

releated crio issues:
cri-o/cri-o#8760
cri-o/cri-o#8764

A PR was opened in crio 1.32 & backported to crio 1.30, 1.31:
cri-o/cri-o#8765
to add option pull_progress_timeout

This PR adds the option to the crio.conf so it can be set if needed (and leave it disabled by default)

Which issue(s) this PR fixes:

Fixes #12554

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

crio: add option pull_progress_timeout

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pedro-peter
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 15, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @pedro-peter. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tico88612
tico88612 reviewed Sep 19, 2025
View reviewed changes
roles/container-engine/cri-o/templates/crio.conf.j2
# ignore; the latter will ignore volumes entirely.
image_volumes = "mkdir"

{% if crio_pull_progress_timeout is defined %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could crio_pull_progress_timeout set the default value instead of is defined?

roles/container-engine/cri-o/defaults/main.yml
crio_selinux: "{{ (preinstall_selinux_state == 'enforcing') | lower }}"
crio_signature_policy: "{% if ansible_os_family == 'ClearLinux' %}/usr/share/defaults/crio/policy.json{% endif %}"
# Override the default pull progress timeout
#crio_pull_progress_timeout: "60s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align with CRI-O default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 left review comments

@yankay yankay Awaiting requested review from yankay

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulling large container images can fail when using crio container runtime
3 participants
@pedro-peter @k8s-ci-robot @tico88612