Hooks into stripped binaries for SSL calls #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluxa
reviewed
May 26, 2025
iluxa
reviewed
May 29, 2025
pkg/hooks/ssl/ssllib_hooks.go
Outdated
| type SslHooks struct { | ||
| links []link.Link | ||
| } | ||
|
|
||
| // TODO: incapsulate, add devuce id to the key, delete on file is deleted | ||
| var hookInodes, _ = lru.New[uint64, uint32](16384) | ||
|
|
||
| func init() { | ||
| if err := offStore.LoadOffsets(offsetdb); err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
panic doesn't look good,
tracer should be able to work without offsetdb
In case if db is not loaded it should skip all the new code in the workflow
There was a problem hiding this comment.
Removed the panic and moved it into an once call
iluxa
approved these changes
Jun 2, 2025
| type SslHooks struct { | ||
| links []link.Link | ||
| } | ||
|
|
||
| // TODO: incapsulate, add devuce id to the key, delete on file is deleted | ||
| var hookInodes, _ = lru.New[uint64, uint32](16384) | ||
|
|
||
| func init() { | ||
| if err := offStore.LoadOffsets(offsetdb); err != nil { |
There was a problem hiding this comment.
This must be duplication of onceFunc part - to be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add hooks into stripped binaries for SSL calls
Changes