Can't access message variables from outside

[adambalint-srg]

Feature Request

Q	A
New Feature	no
RFC	no
BC Break	no

Summary

I'm fighting with the new refactor, and found an other problem. I'm developing an API backend, and the translation stuff happens on frontend, so I'm not rendering the validator messages. I serve the key of the validation message (e.g. NumberComparison.notLessInclusive ), and the variables in it. But getMessageVariables method has been removed, so it is impossible to get details about messages after validation, because:

• Can't extend NumberComaprison validator, because it's final
• With decoration I can't access message variables, because of the missing getMessageVariables
• Can't get options (which can be variables, but it's not sure) from validator, because getters have been removed

The only option is to get out the rendered message, and from this I can't parse the variables.
Why this method has been removed? How do you think I should hack this situation? :/

[gsteel]

I can see your problem here.

As for the why, in future versions of validator we want stateless validators that would return something vaguely like:

final readonly class ErrorResult {
   public false $isValid;
   public mixed $value;
   /** @var array<string, string> Default validation messages */
   public array $messages;
   /** @var array<string, mixed> Variable substitutions */
   public array $variables;
   /** @var list<string> Message Keys */
   public array $messageKeys;
}

See: #153 amongst others.

… Effectively, as many public methods as possible that expose internal state have been removed, and we headed towards immutability as much as we could.

It's no longer possible to add interface methods without breaking BC, but it is possible to add new interfaces.

My opinion is that we should not simply add getMessageVariables() back to AbstractValidator or something along with some kind of ValidatorWithSubstitutionsInterface, but rather look at adding validate(mixed $value): Result so that it can become the default in version 4.0

The latter will take some time because little of the ecosystem is even using 3.x yet and our plates are pretty full just getting other libs up to date with service manager v4.

Are using validator completely standalone?

[adambalint-srg]

@gsteel I love the idea of Result class returned, but yeah I know it's BC, and I have to wait for it.

Are using validator completely standalone?

What to you mean by this? I'm using lot of packages from laminas.

[gsteel]

@adambalint-srg I mean, it's not currently possible to use validator v3 with input-filter, and most other libs still haven't been upgraded to support service-manager v4 - I'm surprised you've got it installed is all.

[adambalint-srg]

@gsteel It's long awaited refactor of our application, so I started it based on new package releases, and ramchale's forks, who is working on the new version. :) For i18n I've made a temporary own fork with some small fixes