feat(langchain): Add timeout to ToolNode ainvoke()
#32935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
mdrxy
changed the title
ToolNode ainvoke()
mdrxy
changed the title
ToolNode ainvoke()ToolNode ainvoke()
mdrxy
added
langchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(langchain): add timeout to ToolNode ainvoke to prevent hangs
Description:
This PR resolves issue #32853, where ToolNode.ainvoke could freeze indefinitely if a tool's execution hangs, particularly with sse_read_timeout configurations.
To address this, I've implemented a timeout mechanism in the ToolNode class:
Added timeout Parameter: A new optional timeout parameter has been added to the ToolNode's init method, allowing users to specify a timeout in seconds.
Asynchronous Timeout Handling: The _afunc method now uses asyncio.wait_for to enforce the timeout on concurrent tool executions. If a timeout occurs, a TimeoutError is raised with an informative message.
Comprehensive Unit Tests: New tests have been added to verify the timeout functionality, including scenarios for timeout exceptions, successful completions, and backward compatibility.
All existing and new tests pass, and the code adheres to the project's linting and formatting standards.
Issue:
Fixes #32853
Dependencies:
None