Skip to content

Conversation

realpvz
Copy link
Contributor

@realpvz realpvz commented Sep 8, 2025

DatabaseTransactionsManager allows registering callbacks with addCallback(). The intended behavior is that these callbacks should run in the same order they were added. While existing tests cover that callbacks are executed, there was no explicit test guaranteeing ordering semantics. Without a regression guard, an internal implementation change could unintentionally reverse or reorder callbacks.

  • Provides a regression test ensuring deterministic FIFO execution.
  • No behavior changes; test-only addition.
  • Improves confidence for future refactors around transaction management.

@taylorotwell taylorotwell merged commit 7f67479 into laravel:12.x Sep 10, 2025
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants