[12.x] Fix 'can' function that was defined in RouterRegistrar in #54648 #57072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that a
canfunction was added to the $allowedAttributes array in PR #54648 but this did not actually work for route groups. This has the potential for security issues in applications that assumecanworks because it's in the allowedAttributes array when it actually doesn't, which for untested endpoints means you could potentially access unauthorized routes. This change adds it to the route middleware when assigning it to the route actions, which makes it work.The test failed before this PR but works after the changes.