Skip to content

Fix not to decode as JSON the empty response body #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix not to decode as JSON the empty response body #1013

merged 2 commits into from
Oct 24, 2024

Conversation

habara-k
Copy link
Contributor

@habara-k habara-k commented Oct 23, 2024 •
edited
Loading

Changes

This PR fixes the issue where JSON deserialization occurs even when the response body is empty.

References

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@habara-k habara-k mentioned this pull request Oct 23, 2024
Closed
@habara-k habara-k self-assigned this Oct 23, 2024
@habara-k habara-k requested a review from mokuzon October 24, 2024 03:39
@habara-k habara-k merged commit 0e0e5b7 into line:master Oct 24, 2024
5 checks passed
@habara-k
Copy link
Contributor Author

https://github.com/line/line-bot-sdk-nodejs/releases/tag/v9.4.2 is released.
Thank you for your review, @mokuzon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokuzon mokuzon mokuzon approved these changes

Assignees

@habara-k habara-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@habara-k @CLAassistant @mokuzon