metrics: remove authority label on inbound http metrics #3547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zahari Dichev <[email protected]>
olix0r
approved these changes
Jan 24, 2025
olix0r
added a commit
that referenced
this pull request
Mar 31, 2025
)" This reverts commit 3ab83ed.
olix0r
added a commit
that referenced
this pull request
Apr 1, 2025
In #3547, we removed unsafe authority labels. This was a breaking change, since the behavior was considered unsafe. To support a graceful migration, this change adds an environment configuration, `LINKERD2_PROXY_INBOUND_AUTHORITY_LABELS=unsafe`, that reverts to the prior behavior. It may be configured in linkerd2 via the proxy.additionalEnv helm value.
olix0r
added a commit
that referenced
this pull request
Apr 1, 2025
In #3547, we removed unsafe authority labels. This was a breaking change, since the behavior was considered unsafe. To support a graceful migration, this change adds an environment configuration, `LINKERD2_PROXY_INBOUND_AUTHORITY_LABELS=unsafe`, that reverts to the prior behavior. It may be configured in linkerd2 via the proxy.additionalEnv helm value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the
authoritylabel on inbound HTTP requests.The label is derived from the Host headers on inbound HTTP requests. This means
that the presence of this label can be exploited by a malicious client in order to produce
unbounded increase in the cardinality of the metrics reported in the proxy by sending
a large amount of HTTP requests with random
Hostheaders.Signed-off-by: Zahari Dichev [email protected]