nit(app/inbound): fix InboundMetrics doc comment
#4078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this comment changes this comment in two ways: 1. fix a copy-paste typo. this should say "inbound", not "outbound". 2. add note that this is a "legacy" structure. the equivalent structure in the outbound proxy was labeled as such in #2887. see: ```rust /// Holds LEGACY outbound proxy metrics. #[derive(Clone, Debug)] pub struct OutboundMetrics { pub(crate) http_errors: error::Http, pub(crate) tcp_errors: error::Tcp, // pub(crate) http_route_backends: RouteBackendMetrics, // pub(crate) grpc_route_backends: RouteBackendMetrics, /// Holds metrics that are common to both inbound and outbound proxies. These metrics are /// reported separately pub(crate) proxy: Proxy, pub(crate) prom: PromMetrics, } ``` \- <https://github.com/linkerd/linkerd2-proxy/blob/dce6b611919d243b57113c1efae68ad302879fc0/linkerd/app/outbound/src/metrics.rs#L22-L35> `authz::HttpAuthzMetrics`, `error::HttpErrorMetrics`, `authz::TcpAuthzMetrics`, and `error::TcpErrorMetrics` all make use of the "legacy" metrics implementation defined in `linkerd_metrics`. Signed-off-by: katelyn martin <[email protected]>
sfleen
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this comment changes this comment in two ways:
the equivalent structure in the outbound proxy was labeled as such in #2887.
see:
linkerd2-proxy/linkerd/app/outbound/src/metrics.rs
Lines 22 to 35 in dce6b61
authz::HttpAuthzMetrics,error::HttpErrorMetrics,authz::TcpAuthzMetrics, anderror::TcpErrorMetricsall make use of the "legacy" metrics implementation defined inlinkerd_metrics.