Fix crossterm use to respect --color option
#1160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to override crossterm module's `NO_COLOR` autodetection with our color flag, so that `--color=...` option correctly overrides the value of `NO_COLOR` in the environment. Fixes lsd-rs#1159 Signed-off-by: Michał Górny <[email protected]>
|
I'm sorry but I don't really understand the meaning of the "TODO" checkboxes. Am I supposed to check them if I have done the relevant bit, or if I haven't done them, so they are "to be done"? |
|
hi @mgorny, never mind the checkboxes, it's for making sure you updated the docs and did tests. can you confirm that this change working as expected when piping result into other commands or files |
I think so.
(same behavior as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to override crossterm module's
NO_COLORautodetection with our color flag, so that--color=...option correctly overrides the value ofNO_COLORin the environment.Fixes #1159
TODO
cargo fmt