CSP: Don't test nonce for truthiness before inclusion #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of version 4.0 of django-csp, the behavior of the object that wraps the nonce in the request and/or context has changed. Testing for truthiness now returns `False` instead of `True`. The truthiness check is unnecessary anyway, skipping it is compatible with all versions of django-csp. Probably more performant too, template rendering wise. Not that it matters.
maxfenv
changed the title
|
Thanks 👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 4.0 of django-csp, the behavior of the object that wraps the nonce in the request and/or context has changed. Testing for truthiness now returns
Falseinstead ofTrue.The truthiness check is unnecessary anyway, skipping it is compatible with all versions of django-csp. Probably more performant too, template rendering wise. Not that it matters.
Link to the PR in django-csp that makes this change: mozilla/django-csp#270
Link to the changelog in django-csp: https://github.com/mozilla/django-csp/blob/main/CHANGES.md#breaking-changes