Introduce <TextArrayField> and use <TextArrayInput> / <TextArrayField> in guessers for scalar arrays
#10939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
changed the title
TextArrayInput / TextArrayField in guessers for scalar arrays<TextArrayField> and use <TextArrayInput> / <TextArrayField> in guessers for scalar arrays
Madeorsk
reviewed
Sep 16, 2025
Co-authored-by: Madeorsk <[email protected]>
Madeorsk
approved these changes
Sep 17, 2025
fzaninotto
reviewed
Sep 17, 2025
|
|
||
| The following props are available for `<TextArrayField>`: | ||
|
|
||
| | Prop | Type | Required | Description | |
There was a problem hiding this comment.
Nitpick: the Required column is the second one in all prop tables, here it's the third. Also, we usually include a Default column.
There was a problem hiding this comment.
okay I'll change that on master
UPDATE: I mean on next
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
EditGuesserassumes that every array is an array of objects. If we detect values that are scalar arrays, the guesser will use aTextInput, which is not correct.Solution
Detect scalar arrays in introspection, and use:
TextArrayInputinEditGuesserTextArrayField(a list of Chips in a Stack, to be invented) forListGuesserandShowGuesserHow To Test
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.