fix: Stop pipes before stopping screenpipe sidecar #1792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 testing bounty created!a testing bounty has been created for this PR: view testing issue testers will be awarded $20 each for providing quality test reports. please check the issue for testing requirements. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: pull request
about: submit changes to the project
title: "[pr] "
labels: ''
assignees: ''
description
I noticed that stopping the screenpipe sidecar on Linux using the UI app causes the UI itself to terminate. I'm not sure if this behavior occurs on other platforms. The solution I found is to stop the pipes before stopping the screenpipe sidecar, which prevents the UI from crashing.
This PR implements that fix.
related issue: #
how to test
add a few steps to test the pr in the most time efficient way.
if relevant add screenshots or screen captures to prove that this PR works to save us time (check Cap).
if you are not the author of this PR and you see it and you think it can take more than 30 mins for maintainers to review, we will tip you between $20 and $200 for you to review and test it for us.