Detects header changes with windows.compile_resources #14977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruchar1
force-pushed
the
windows_rc_deps
branch
3 times, most recently
from
9180f25 to
373c9b6
Compare
eli-schwartz
reviewed
Sep 4, 2025
eli-schwartz
reviewed
Sep 4, 2025
was wrongly tagged in 59c3dd1
The `rc.exe` resource compiler neither provides *depfile* support nor allows showing includes, as is possible with C or C++ compilers. Therefore, changes to files included by the `.rc` file did not trigger recompilation of the resource file. A workaround was added to *meson* by calling the preprocessor on the `.rc` file to detect the included headers and adding the result as a dependency to the resource compilation.
bruchar1
force-pushed
the
windows_rc_deps
branch
from
373c9b6 to
519960a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rc.exeresource compiler neither provides depfile support norallows showing includes, as is possible with C or C++ compilers.
Therefore, changes to files included by the
.rcfile did not triggerrecompilation of the resource file.
A workaround was added to meson by calling the preprocessor on the
.rcfile to detect the included headers and adding the result as adependency to the resource compilation.