Make jvm.classes.unloaded description generic #5745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description before could have been confusing for step-based registries where the number would be the classes unloaded since the previous step rather than the cumulative count since the JVM started. See micrometer-metricsgh-3561
shakuzen
added
enhancement
jonatan-ivanov
approved these changes
Dec 17, 2024
|
I think GitHub was having stability issues yesterday when I tried to merge this. It looks like it is already merged, despite what the GH UI shows right now. See 3383e5c |
lenin-jaganathan
pushed a commit
to lenin-jaganathan/micrometer
that referenced
this pull request
Dec 18, 2024
The description before could have been confusing for step-based registries where the number would be the classes unloaded since the previous step rather than the cumulative count since the JVM started. See micrometer-metricsgh-3561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description before could have been confusing for step-based registries where the number would be the classes unloaded since the previous step rather than the cumulative count since the JVM started.
See gh-3561