AzureCLI V3 task with Azure DevOps Service Connection support #21229
Conversation
Tasks/AzureCLIV3/azureclitask.ts
Outdated
| Utility.throwIfError(tl.execSync("az", `devops configure --defaults project="${project}"`), tl.loc("FailedToSetAzureDevOpsProject")); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Please fix the indentation here for closing curly bracet.
Also I recommend throwing an error here if authScheme.toLowerCase() != "workloadidentityfederation"
There was a problem hiding this comment.
Yes, I agree. I’ve added an error for that case
Tasks/AzureCLIV3/azureclitask.ts
Outdated
| if (project) { | ||
| Utility.throwIfError(tl.execSync("az", `devops configure --defaults project="${project}"`), tl.loc("FailedToSetAzureDevOpsProject")); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove redundant empty line here
There was a problem hiding this comment.
Removed, thank you!
Tasks/AzureCLIV3/azureclitask.ts
Outdated
| tl.setSecret(federatedToken); | ||
| let args = `login --service-principal -u "${servicePrincipalId}" --tenant "${tenantId}" --allow-no-subscriptions --federated-token "${federatedToken}"`; | ||
|
|
||
| if(!visibleAzLogin ){ |
There was a problem hiding this comment.
Please add white spaces for If (...) condition - like it's done in in this method below
There was a problem hiding this comment.
White spaces added, thank you!
tpavlovi
changed the title
| const project = tl.getVariable('System.TeamProject'); | ||
|
|
||
| if (organization) { | ||
| Utility.throwIfError(tl.execSync("az", `devops configure --defaults organization="${organization}"`), tl.loc("FailedToSetAzureDevOpsOrganization")); |
There was a problem hiding this comment.
Should not we clean these settings once the task is completed?
There was a problem hiding this comment.
Would it be okay to proceed like this?
az devops configure --defaults organization='' project=''
Tasks/AzureCLIV3/Tests/L0.ts
Outdated
| }); | ||
|
|
||
| it('Does a basic hello world test', function (done: MochaDone) { | ||
| // TODO - add real tests |
There was a problem hiding this comment.
Don't forget to add some real tests. :)
There was a problem hiding this comment.
Thank you, tests have been added!
Tasks/AzureCLIV3/Tests/package.json
Outdated
| { | ||
| "name": "azure-cli-tests", | ||
| "version": "1.0.0", | ||
| "description": "Azure Pipelines Azure CLI V2 Task Tests", |
There was a problem hiding this comment.
Here it still says V2. Maybe check the whole folder for unintentional mentions of V2 where V3 needs to be used instead.
There was a problem hiding this comment.
I agree, thank you!
Context
The new version of the task for Azure CLI supports Azure DevOps service connections. Regarding the ARM connection type, everything remains the same as in AzureCLI v2. However, when using Azure DevOps service connections, the following occurs:
Task Name
AzureCLIV3
Description
Added new
connectionTypeinput with options:azureRM(default)azureDevOps- New support for Azure DevOps service connectionsMethod
setupAzureDevOpsCLI():az extension add -n azure-devops -yNew error messages:
FailedToInstallAzureDevOpsCLI- "Failed to install Azure DevOps CLI extension",FailedToSetAzureDevOpsOrganization- "Failed to set Azure DevOps organization",FailedToSetAzureDevOpsProject- "Failed to set Azure DevOps project"Risk Assessment (Low / Medium / High)
Assess the level of risk and provide reasoning (e.g., scope, impact, backward compatibility).
Change Behind Feature Flag (Yes/No)
There’s no need to add a feature flag. If needed, the user can switch to V2.
Tech Design / Approach
Documentation Changes Required (Yes/No)
Yes
Unit Tests Added or Updated (Yes/No)
No
Additional Testing Performed
The task has been tested within the organization on Ring-1 and in DevFabric
Logging Added/Updated (Yes/No)
Yes
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
If a rollback is needed, the user can switch to a different task version
Dependency Impact Assessed and Regression Tested (Yes/No)
No
Checklist