Skip to content

fix: [#4859] Inconsistent ConversationParameters interface #4873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
+2 −2
Merged

fix: [#4859] Inconsistent ConversationParameters interface #4873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
990e6bf
Mark activity as optional in ConversationParameters
ceciliaavila Mar 31, 2025
12b722e
Merge branch 'main' into southworks/update/conversation-parameters-ac…
ceciliaavila Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/botframework-schema/etc/botframework-schema.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ export interface ConversationMembers {

// @public
export interface ConversationParameters {
activity: Activity;
activity?: Activity;
bot: ChannelAccount;
channelData: any;
isGroup: boolean;
Expand Down
2 changes: 1 addition & 1 deletion libraries/botframework-schema/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,7 @@ export interface ConversationParameters {
* (Optional) When creating a new conversation, use this activity as the initial message to the
* conversation
*/
activity: Activity;
activity?: Activity;
/**
* Channel specific payload for creating the conversation
*/
Expand Down
Loading