Skip to content

FHIR Model and temporarily cached data #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 10, 2024
Merged

FHIR Model and temporarily cached data #3705

merged 5 commits into from
Feb 10, 2024
+396 −12

Conversation

fhibf
Copy link
Contributor

@fhibf fhibf commented Feb 8, 2024

Description

Describe the changes in this PR.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@fhibf fhibf requested a review from a team as a code owner February 8, 2024 01:06
@fhibf fhibf added this to the S134 milestone Feb 8, 2024
@fhibf fhibf added Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality. Enhancement-Optimization Optimization on existing functionality. labels Feb 8, 2024
@fhibf
Improvements in FhirMemoryCache.
0b13202 
Adding sliding expiration.
Increased default caching for 24 hours.
@fhibf fhibf changed the title FHIR Model and temporally cached data FHIR Model and temporarily cached data Feb 9, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 9, 2024
View reviewed changes
src/Microsoft.Health.Fhir.Core/Features/Storage/FhirMemoryCache.cs
Comment on lines +78 to +86
if (cachedItem.Value == null)
{
// If the item cache item is null, then the item was added to the cache.
return (T)newCacheItem.Value;
}
else
{
return (T)cachedItem.Value;
}

Check notice

Code scanning / CodeQL

Missed ternary opportunity

Both branches of this 'if' statement return - consider using '?' to express intent better.
@fhibf fhibf merged commit 869dbab into main Feb 10, 2024
@fhibf fhibf deleted the personal/fhibf/useMemoryCache branch February 10, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feordin feordin feordin left review comments

@brendankowitz brendankowitz brendankowitz approved these changes

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality. Enhancement-Optimization Optimization on existing functionality.
Projects
None yet
Milestone
S134
Development

Successfully merging this pull request may close these issues.
3 participants
@fhibf @brendankowitz @feordin