.Net Fix #10964 Gemini typeof(T) schema breaks logging #10993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gging doesn't fail when using typeof(T)
markwallace-microsoft
added
.NET
|
@microsoft-github-policy-service agree company="Claim Mosaic" |
rogerbarreto
approved these changes
Mar 15, 2025
There was a problem hiding this comment.
Hi @sscowden Thanks for the first contribution!
Just one observation. Change the public to be an internal
Looks good to me.
dotnet/src/Connectors/Connectors.Google/Core/Gemini/Models/GeminiRequest.cs
Outdated
Show resolved
Hide resolved
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
temporarily deployed
to
integration
GitHub Actions
Inactive
Hey Roger, sorry I didn't get to this in time. Thank you for completing the PR! |
markwallace-microsoft
approved these changes
Mar 18, 2025
github-project-automation
bot
moved this from Community PRs
to Sprint: Done
in Semantic Kernel
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…osoft#10993) Fixes microsoft#10964 Feedback welcome, wasn't really sure on how I should approach this, but opted to add a Moq logger to the existing Gemini ResponseSchema test. This required me to make `GeminiRequest.GetResponseSchemaConfig` public and add an optional ILogger parameter to `GeminiChatGenerationTests.CreateChatCompletionClient`. --------- Co-authored-by: Roger Barreto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10964
Feedback welcome, wasn't really sure on how I should approach this, but opted to add a Moq logger to the existing Gemini ResponseSchema test. This required me to make
GeminiRequest.GetResponseSchemaConfigpublic and add an optional ILogger parameter toGeminiChatGenerationTests.CreateChatCompletionClient.