Skip to content

Conversation

moonbox3
Copy link
Collaborator

@moonbox3 moonbox3 commented Apr 7, 2025

Motivation and Context

AzureAIAgents, OpenAIAssistantAgents, and OpenAIResponsesAgents previously were not covered by integration tests. Adding a set of integration tests to cover high-level usage of an AzureAIAgent and OpenAIAssistantAgents for get_response, invoke, and invoke_stream.

As part of this work, a previous fix to typing caused a regression while generating FunctionCallContent for an AzureAIAgent. Fixing to use the correct instance check.

Description

Adds integration tests for AzureAIAgent and OpenAIAssistantAgent.

Contribution Checklist

@moonbox3 moonbox3 added docs and tests Improvements or additions to documentation agents labels Apr 7, 2025
@moonbox3 moonbox3 self-assigned this Apr 7, 2025
@moonbox3 moonbox3 requested a review from a team as a code owner April 7, 2025 03:32
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Apr 7, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Apr 7, 2025

Python Unit Test Overview

Tests Skipped Failures Errors Time
3418 5 💤 0 ❌ 0 🔥 1m 39s ⏱️

@moonbox3 moonbox3 enabled auto-merge April 7, 2025 03:35
@moonbox3 moonbox3 disabled auto-merge April 7, 2025 05:02
@moonbox3 moonbox3 changed the title Python: AzureAIAgent Integration tests and AzureAIAgent FCC gen bug fix Python: AzureAIAgent & OpenAIAssistant Integration tests and AzureAIAgent FCC gen bug fix Apr 7, 2025
@moonbox3 moonbox3 enabled auto-merge April 7, 2025 05:57
eavanvalkenburg
eavanvalkenburg previously approved these changes Apr 7, 2025
eavanvalkenburg
eavanvalkenburg previously approved these changes Apr 7, 2025
@moonbox3 moonbox3 disabled auto-merge April 7, 2025 07:52
@moonbox3 moonbox3 changed the title Python: AzureAIAgent & OpenAIAssistant Integration tests and AzureAIAgent FCC gen bug fix Python: add AzureAIAgent, OpenAIAssistant and OpenAIResponsesAgent Integration tests, AzureAIAgent FCC gen bug fix Apr 7, 2025
@moonbox3 moonbox3 enabled auto-merge April 7, 2025 09:06
eavanvalkenburg
eavanvalkenburg previously approved these changes Apr 7, 2025
westey-m
westey-m previously approved these changes Apr 7, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Apr 7, 2025
@moonbox3 moonbox3 removed this pull request from the merge queue due to a manual request Apr 7, 2025
@moonbox3 moonbox3 dismissed stale reviews from westey-m and eavanvalkenburg via 21b3f25 April 7, 2025 09:28
@moonbox3 moonbox3 added this pull request to the merge queue Apr 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 7, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 0ff97c7 Apr 7, 2025
28 checks passed
@eavanvalkenburg eavanvalkenburg deleted the feature-agent-int-tests branch April 7, 2025 11:01
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Apr 7, 2025
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request May 6, 2025
…tegration tests, AzureAIAgent FCC gen bug fix (microsoft#11394)

### Motivation and Context

AzureAIAgents, OpenAIAssistantAgents, and OpenAIResponsesAgents
previously were not covered by integration tests. Adding a set of
integration tests to cover high-level usage of an AzureAIAgent and
OpenAIAssistantAgents for `get_response`, `invoke`, and `invoke_stream`.

As part of this work, a previous fix to typing caused a regression while
generating FunctionCallContent for an AzureAIAgent. Fixing to use the
correct instance check.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

Adds integration tests for AzureAIAgent and OpenAIAssistantAgent.
- Fixes microsoft#11393
- Bump version to 1.27.2 for bug fix release.
- Remove unnecessary yield for function result content during streaming
invocation - these types will be added if the `on_intermediate_message`
callback is provided.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
…tegration tests, AzureAIAgent FCC gen bug fix (microsoft#11394)

### Motivation and Context

AzureAIAgents, OpenAIAssistantAgents, and OpenAIResponsesAgents
previously were not covered by integration tests. Adding a set of
integration tests to cover high-level usage of an AzureAIAgent and
OpenAIAssistantAgents for `get_response`, `invoke`, and `invoke_stream`.

As part of this work, a previous fix to typing caused a regression while
generating FunctionCallContent for an AzureAIAgent. Fixing to use the
correct instance check.

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

Adds integration tests for AzureAIAgent and OpenAIAssistantAgent.
- Fixes microsoft#11393
- Bump version to 1.27.2 for bug fix release.
- Remove unnecessary yield for function result content during streaming
invocation - these types will be added if the `on_intermediate_message`
callback is provided.

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents docs and tests Improvements or additions to documentation python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Python: Bug: AzureAIAgents don't properly form FunctionCallContent due to incorrect instance check
4 participants