Skip to content

Conversation

KanchiShimono
Copy link
Contributor

Motivation and Context

Resolves #11457

Description

Fixed an issue where a TypeError would occur when the inputSchema of a tool listed from the MCP server did not include any required parameters.

Contribution Checklist

@KanchiShimono KanchiShimono requested a review from a team as a code owner April 9, 2025 03:13
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Apr 9, 2025
@github-actions github-actions bot changed the title Fix TypeError when required is missing in MCP tool’s inputSchema Python: Fix TypeError when required is missing in MCP tool’s inputSchema Apr 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@moonbox3
Copy link
Collaborator

moonbox3 commented Apr 9, 2025

Thanks for the fix, @KanchiShimono.

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Apr 9, 2025

Python Unit Test Overview

Tests Skipped Failures Errors Time
3418 5 💤 0 ❌ 0 🔥 1m 39s ⏱️

@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@eavanvalkenburg eavanvalkenburg removed this pull request from the merge queue due to a manual request Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@eavanvalkenburg eavanvalkenburg removed this pull request from the merge queue due to a manual request Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@eavanvalkenburg eavanvalkenburg removed this pull request from the merge queue due to a manual request Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 9, 2025
Merged via the queue into microsoft:main with commit 7e376b7 Apr 9, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this to Sprint: Done in Semantic Kernel Apr 9, 2025
@KanchiShimono KanchiShimono deleted the fix-python-mcp-tool-required-param-checking branch April 26, 2025 11:15
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request May 6, 2025
…chema (microsoft#11458)

### Motivation and Context

Resolves microsoft#11457

### Description

Fixed an issue where a `TypeError` would occur when the inputSchema of a
tool listed from the MCP server did not include any required parameters.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Python: Bug: MCP plugin raises TypeError for undefined required parameter in MCP tool inputSchema
4 participants