-
Notifications
You must be signed in to change notification settings - Fork 4.2k
.Net: BugFix 400 BadRequest for ToolcallBehavior against Google API #12365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rogerbarreto
merged 6 commits into
microsoft:main
from
rogerbarreto:issues/11629-google-chat-completion
Jun 5, 2025
Merged
.Net: BugFix 400 BadRequest for ToolcallBehavior against Google API #12365
rogerbarreto
merged 6 commits into
microsoft:main
from
rogerbarreto:issues/11629-google-chat-completion
Jun 5, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ IT updates + added support for numerical parameters
dotnet/src/Connectors/Connectors.Google/Core/Gemini/GeminiPluginCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
westey-m
approved these changes
Jun 4, 2025
markwallace-microsoft
approved these changes
Jun 4, 2025
SergeyMenshykh
approved these changes
Jun 5, 2025
…com/rogerbarreto/semantic-kernel into issues/11629-google-chat-completion
SergeyMenshykh
approved these changes
Jun 5, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…icrosoft#12365) # Motivation - Fixes microsoft#11629 As demonstrated in the issue above, attempting to call Google Gemini using the ToolcallBehavior logic (current only one supported in this connector) an unexpected error was raising when sending a complex json schema structure from github MCP tooling, this bugfix removes non supported `additionalParameters` property sent into the schema for the API. - Additionally to the changes we added support for numeric and boolean parameters for function calling. - After this change the example in the Issue should work with `ToolcallBehavior`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As demonstrated in the issue above, attempting to call Google Gemini using the ToolcallBehavior logic (current only one supported in this connector) an unexpected error was raising when sending a complex json schema structure from github MCP tooling, this bugfix removes non supported
additionalParameters
property sent into the schema for the API.ToolcallBehavior
.