.Net: Fix Labels Implementation in Vertex AI to Use Dictionary<string, string> #12636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 2, 2025 14:30
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
|
Hi @markwallace-microsoft / @rogerbarreto, could you please help reviewing this PR? |
markwallace-microsoft
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
LGTM but I have not tested the changes. @rogerbarreto can you test this?
Hi @rogerbarreto, could you please help? |
rogerbarreto
approved these changes
Jul 8, 2025
markwallace-microsoft
approved these changes
Jul 8, 2025
jcruzmot-te
pushed a commit
to thousandeyes/aia-semantic-kernel
that referenced
this pull request
Sep 15, 2025
…, string> (microsoft#12636) ### Description This pull request addresses issue microsoft#12633 by updating the Labels property in the `GeminiPromptExecutionSettings` and `GeminiRequest` classes to use a `Dictionary<string, string>` instead of a string. This change aligns the implementation with the Vertex AI API requirements, which expect labels to be sent as key-value pairs in JSON format. Fixes microsoft#12633 --------- Co-authored-by: Adit Sheth <[email protected]> Co-authored-by: Roger Barreto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses issue #12633 by updating the Labels property in the
GeminiPromptExecutionSettingsandGeminiRequestclasses to use aDictionary<string, string>instead of a string. This change aligns the implementation with the Vertex AI API requirements, which expect labels to be sent as key-value pairs in JSON format.Fixes #12633