Simplify labeler rules for kernel label #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemillermicrosoft
added
the
PR: ready for review
shawncal
approved these changes
Apr 28, 2023
Summary: This commit simplifies the labeler rules for the kernel label by using the any and all operators instead of a list of patterns. This makes the rules more readable and easier to maintain. The logic of the rules remains the same, as they still exclude the SemanticKernel and SemanticKernel.Abstractions projects from the kernel label.
shawncal
force-pushed
the
427_labeler_fix
branch
from
6a89da9 to
78c5670
Compare
5 tasks
lemillermicrosoft
added a commit
that referenced
this pull request
Apr 28, 2023
### Motivation and Context #710 tried to enable the `kernel` tag but accidentally applied to too many changes. ### Description The best way to resolve this was specify directories under `dotnet` to be considered for `kernel`. lemillermicrosoft#7 lemillermicrosoft#8 lemillermicrosoft#10 lemillermicrosoft#9 This one was missed before.
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
This commit simplifies the labeler rules for the kernel label by using the any and all operators instead of a list of patterns. This makes the rules more readable and easier to maintain and ensures `kernel` label is used as appropriate. The logic of the rules still exclude the SemanticKernel and SemanticKernel.Abstractions projects from the kernel label but will now include if only non-core kernel changes are made.
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context #710 tried to enable the `kernel` tag but accidentally applied to too many changes. ### Description The best way to resolve this was specify directories under `dotnet` to be considered for `kernel`. lemillermicrosoft#7 lemillermicrosoft#8 lemillermicrosoft#10 lemillermicrosoft#9 This one was missed before.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
This commit simplifies the labeler rules for the kernel label by using the any and all operators instead of a list of patterns. This makes the rules more readable and easier to maintain and ensures `kernel` label is used as appropriate. The logic of the rules still exclude the SemanticKernel and SemanticKernel.Abstractions projects from the kernel label but will now include if only non-core kernel changes are made.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context microsoft#710 tried to enable the `kernel` tag but accidentally applied to too many changes. ### Description The best way to resolve this was specify directories under `dotnet` to be considered for `kernel`. #7 #8 #10 #9 This one was missed before.
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
This commit simplifies the labeler rules for the kernel label by using the any and all operators instead of a list of patterns. This makes the rules more readable and easier to maintain and ensures `kernel` label is used as appropriate. The logic of the rules still exclude the SemanticKernel and SemanticKernel.Abstractions projects from the kernel label but will now include if only non-core kernel changes are made.
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context microsoft#710 tried to enable the `kernel` tag but accidentally applied to too many changes. ### Description The best way to resolve this was specify directories under `dotnet` to be considered for `kernel`. lemillermicrosoft#7 lemillermicrosoft#8 lemillermicrosoft#10 lemillermicrosoft#9 This one was missed before.
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
This commit simplifies the labeler rules for the kernel label by using the any and all operators instead of a list of patterns. This makes the rules more readable and easier to maintain and ensures `kernel` label is used as appropriate. The logic of the rules still exclude the SemanticKernel and SemanticKernel.Abstractions projects from the kernel label but will now include if only non-core kernel changes are made.
johnoliver
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
### Motivation and Context microsoft#710 tried to enable the `kernel` tag but accidentally applied to too many changes. ### Description The best way to resolve this was specify directories under `dotnet` to be considered for `kernel`. lemillermicrosoft#7 lemillermicrosoft#8 lemillermicrosoft#10 lemillermicrosoft#9 This one was missed before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies the labeler rules for the kernel label by using the any and all operators instead of a list of patterns. This makes the rules more readable and easier to maintain and ensures
kernellabel is used as appropriate. The logic of the rules still exclude the SemanticKernel and SemanticKernel.Abstractions projects from the kernel label but will now include if only non-core kernel changes are made.lemillermicrosoft#7
lemillermicrosoft#8
lemillermicrosoft#9
Contribution Checklist
dotnet format