Skip to content

Conversation

dluc
Copy link
Contributor

@dluc dluc commented Apr 30, 2023

Motivation and Context

When configuring AI models (text completion, embeddings, chat, image generation, etc) currently one has to pass a "service Id", ie assign a name to the configuration. This allows apps to work with different models providing the same features, e.g. working with OpenAI and Azure OpenAI and HuggingFace at the same time.

In many scenarios though, there is only one AI model/service provider, e.g. an app might be using just Open AI, and in this case service names are unused.

Also, the kernel config API allows to remove AI models from the configuration, a tentative feature that has never been used and can be removed for now, and reintroduced if we find scenarios or get explicit requests.

Description

  • Make the Service ID optional, making the AI configuration simpler
  • Remove some unused API, reducing the complexity of kernel config

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Apr 30, 2023
@dluc dluc force-pushed the dluc131serviceId branch from 57aa99c to 946503f Compare April 30, 2023 21:09
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label Apr 30, 2023
@dluc dluc force-pushed the dluc131serviceId branch from 946503f to edb9521 Compare April 30, 2023 21:11
@github-actions github-actions bot removed the python Pull requests for the Python Semantic Kernel label Apr 30, 2023
@dluc dluc force-pushed the dluc131serviceId branch from 8741f8e to e6aea7a Compare April 30, 2023 21:28
@dluc dluc force-pushed the dluc131serviceId branch from e6aea7a to 51f5685 Compare April 30, 2023 21:33
@dluc dluc added the PR: ready for review All feedback addressed, ready for reviews label Apr 30, 2023
@dluc dluc requested a review from adrianwyatt May 1, 2023 16:54
@adrianwyatt adrianwyatt self-assigned this May 1, 2023
@adrianwyatt adrianwyatt enabled auto-merge (squash) May 1, 2023 17:30
@adrianwyatt adrianwyatt merged commit 57cbc93 into microsoft:main May 1, 2023
awharrison-28 pushed a commit to awharrison-28/semantic-kernel that referenced this pull request May 1, 2023
### Motivation and Context

When configuring AI models (text completion, embeddings, chat, image
generation, etc) currently one has to pass a "service Id", ie assign a
name to the configuration. This allows apps to work with different
models providing the same features, e.g. working with OpenAI and Azure
OpenAI and HuggingFace at the same time.

In many scenarios though, there is only one AI model/service provider,
e.g. an app might be using just Open AI, and in this case service names
are unused.

Also, the kernel config API allows to remove AI models from the
configuration, a tentative feature that has never been used and can be
removed for now, and reintroduced if we find scenarios or get explicit
requests.

### Description

* Make the Service ID optional, making the AI configuration simpler
* Remove some unused API, reducing the complexity of kernel config

Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
codebrain pushed a commit to searchpioneer/semantic-kernel that referenced this pull request May 16, 2023
### Motivation and Context

When configuring AI models (text completion, embeddings, chat, image
generation, etc) currently one has to pass a "service Id", ie assign a
name to the configuration. This allows apps to work with different
models providing the same features, e.g. working with OpenAI and Azure
OpenAI and HuggingFace at the same time.

In many scenarios though, there is only one AI model/service provider,
e.g. an app might be using just Open AI, and in this case service names
are unused.

Also, the kernel config API allows to remove AI models from the
configuration, a tentative feature that has never been used and can be
removed for now, and reintroduced if we find scenarios or get explicit
requests.

### Description

* Make the Service ID optional, making the AI configuration simpler
* Remove some unused API, reducing the complexity of kernel config

Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context

When configuring AI models (text completion, embeddings, chat, image
generation, etc) currently one has to pass a "service Id", ie assign a
name to the configuration. This allows apps to work with different
models providing the same features, e.g. working with OpenAI and Azure
OpenAI and HuggingFace at the same time.

In many scenarios though, there is only one AI model/service provider,
e.g. an app might be using just Open AI, and in this case service names
are unused.

Also, the kernel config API allows to remove AI models from the
configuration, a tentative feature that has never been used and can be
removed for now, and reintroduced if we find scenarios or get explicit
requests.

### Description

* Make the Service ID optional, making the AI configuration simpler
* Remove some unused API, reducing the complexity of kernel config

Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
@dluc dluc deleted the dluc131serviceId branch June 14, 2023 01:14
@dluc dluc restored the dluc131serviceId branch June 14, 2023 01:14
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context

When configuring AI models (text completion, embeddings, chat, image
generation, etc) currently one has to pass a "service Id", ie assign a
name to the configuration. This allows apps to work with different
models providing the same features, e.g. working with OpenAI and Azure
OpenAI and HuggingFace at the same time.

In many scenarios though, there is only one AI model/service provider,
e.g. an app might be using just Open AI, and in this case service names
are unused.

Also, the kernel config API allows to remove AI models from the
configuration, a tentative feature that has never been used and can be
removed for now, and reintroduced if we find scenarios or get explicit
requests.

### Description

* Make the Service ID optional, making the AI configuration simpler
* Remove some unused API, reducing the complexity of kernel config

Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants