-
Notifications
You must be signed in to change notification settings - Fork 4.2k
API simplification: make AI service ID optional #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianwyatt
approved these changes
May 1, 2023
adrianwyatt
approved these changes
May 1, 2023
awharrison-28
pushed a commit
to awharrison-28/semantic-kernel
that referenced
this pull request
May 1, 2023
### Motivation and Context When configuring AI models (text completion, embeddings, chat, image generation, etc) currently one has to pass a "service Id", ie assign a name to the configuration. This allows apps to work with different models providing the same features, e.g. working with OpenAI and Azure OpenAI and HuggingFace at the same time. In many scenarios though, there is only one AI model/service provider, e.g. an app might be using just Open AI, and in this case service names are unused. Also, the kernel config API allows to remove AI models from the configuration, a tentative feature that has never been used and can be removed for now, and reintroduced if we find scenarios or get explicit requests. ### Description * Make the Service ID optional, making the AI configuration simpler * Remove some unused API, reducing the complexity of kernel config Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
### Motivation and Context When configuring AI models (text completion, embeddings, chat, image generation, etc) currently one has to pass a "service Id", ie assign a name to the configuration. This allows apps to work with different models providing the same features, e.g. working with OpenAI and Azure OpenAI and HuggingFace at the same time. In many scenarios though, there is only one AI model/service provider, e.g. an app might be using just Open AI, and in this case service names are unused. Also, the kernel config API allows to remove AI models from the configuration, a tentative feature that has never been used and can be removed for now, and reintroduced if we find scenarios or get explicit requests. ### Description * Make the Service ID optional, making the AI configuration simpler * Remove some unused API, reducing the complexity of kernel config Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context When configuring AI models (text completion, embeddings, chat, image generation, etc) currently one has to pass a "service Id", ie assign a name to the configuration. This allows apps to work with different models providing the same features, e.g. working with OpenAI and Azure OpenAI and HuggingFace at the same time. In many scenarios though, there is only one AI model/service provider, e.g. an app might be using just Open AI, and in this case service names are unused. Also, the kernel config API allows to remove AI models from the configuration, a tentative feature that has never been used and can be removed for now, and reintroduced if we find scenarios or get explicit requests. ### Description * Make the Service ID optional, making the AI configuration simpler * Remove some unused API, reducing the complexity of kernel config Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context When configuring AI models (text completion, embeddings, chat, image generation, etc) currently one has to pass a "service Id", ie assign a name to the configuration. This allows apps to work with different models providing the same features, e.g. working with OpenAI and Azure OpenAI and HuggingFace at the same time. In many scenarios though, there is only one AI model/service provider, e.g. an app might be using just Open AI, and in this case service names are unused. Also, the kernel config API allows to remove AI models from the configuration, a tentative feature that has never been used and can be removed for now, and reintroduced if we find scenarios or get explicit requests. ### Description * Make the Service ID optional, making the AI configuration simpler * Remove some unused API, reducing the complexity of kernel config Co-authored-by: Adrian Bonar (HE/HIM) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kernel
Issues or pull requests impacting the core kernel
.NET
Issue or Pull requests regarding .NET code
PR: ready for review
All feedback addressed, ready for reviews
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When configuring AI models (text completion, embeddings, chat, image generation, etc) currently one has to pass a "service Id", ie assign a name to the configuration. This allows apps to work with different models providing the same features, e.g. working with OpenAI and Azure OpenAI and HuggingFace at the same time.
In many scenarios though, there is only one AI model/service provider, e.g. an app might be using just Open AI, and in this case service names are unused.
Also, the kernel config API allows to remove AI models from the configuration, a tentative feature that has never been used and can be removed for now, and reintroduced if we find scenarios or get explicit requests.
Description