fix implementation to return embedding #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hsm207 <[email protected]>
shawncal
force-pushed
the
memory-record-loop
branch
from
5d439f5 to
ec9fc0e
Compare
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
calling the memory record's embedding property throws `RecursionError: maximum recursion depth exceeded` return the attribute instead of the property Signed-off-by: hsm207 <[email protected]>
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
calling the memory record's embedding property throws `RecursionError: maximum recursion depth exceeded` return the attribute instead of the property Signed-off-by: hsm207 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
because calling the memory record's embedding property throws
RecursionError: maximum recursion depth exceededcalling the memory record's embedding property throws
RecursionError: maximum recursion depth exceededpeople calling the embedding attribute of a memory memory record
NA
Description
return the attribute instead of the property
Contribution Checklist
dotnet format